Upgrade to Guzzle 6.x

Mathieu REHO shared this idea 8 months ago

Under Consideration

Actually, WHMCS is using the library Guzzle 5.3.1. Some new library requires to use Guzzle 6, so it may be useful to upgrade to version 6.

I like this idea 0

Comments (7)

WHMCS John ● 8 months ago

Hi there,

Thanks for your suggestion.

We monitor for updates to our dependencies and include them when security or new funcitonality we wish to leverage requres it. Due to the major version bump in Guzzle indicating backwards incompatible changes, we would likely also need to reserve such a change to a major version change of our own (eg. v6, v7, v8).

Reply URL

Björn Strausmann ● 8 months ago

Better is the change to HTTPlug...

Reply URL

Daniel McDonald ● 8 months ago

we have massive problems too, with that. Regarding many Modules....

Reply URL

WHMCS John ● 8 months ago

Hi Dainel,

Which problems are you experiencing and with which modules? We are not currently aware of any Guzzle-related issues in any of the stock modules distributed in WHMCS.

URL

Björn Strausmann ● 8 months ago

Modules with Guzzle 6 breaks the WHMCS Updates Task from the daily cron job. For example, a module with the cloudflare-sdk composer package.

URL

WHMCS John ● 8 months ago

Hi Björn,

Thanks for that information. It's the responsibility of the module developer to ensure that their code is compatible with the WHMCS software and its dependencies, not the other way round. The vendor would need to adjust their code to work within our current framework.

URL

Thomas ● 4 months ago

Although I partly agree with the responsibility of the module developer, I wonder what feature requires third party modules to be included during the update process. We're having similar issues but unfortunately we can't rewrite our code because Guzzle is a dependency of on of our own dependencies.

If you ask me WHMCS should make an effort to either keep its dependencies up-to-date or allow for better separation between composer packages in WHMCS and modules. I understand that Guzzle 5 is still in maintenance but version 6 was released in 2015 already, it was released before the version you're currently using.

Either way a big +1 from me.

URL