Upgrade to Guzzle 6.x

WHMCS John ● 1 year ago

Hi there,

Thanks for your suggestion.

We monitor for updates to our dependencies and include them when security or new funcitonality we wish to leverage requres it. Due to the major version bump in Guzzle indicating backwards incompatible changes, we would likely also need to reserve such a change to a major version change of our own (eg. v6, v7, v8).

URL

1

Björn Strausmann ● 1 year ago

Better is the change to HTTPlug...

URL

1

Daniel M ● 1 year ago

we have massive problems too, with that. Regarding many Modules....

URL

1

WHMCS John ● 1 year ago

Hi Dainel,

Which problems are you experiencing and with which modules? We are not currently aware of any Guzzle-related issues in any of the stock modules distributed in WHMCS.

URL

1

Björn Strausmann ● 1 year ago

Modules with Guzzle 6 breaks the WHMCS Updates Task from the daily cron job. For example, a module with the cloudflare-sdk composer package.

URL

1

WHMCS John ● 1 year ago

Hi Björn,

Thanks for that information. It's the responsibility of the module developer to ensure that their code is compatible with the WHMCS software and its dependencies, not the other way round. The vendor would need to adjust their code to work within our current framework.

URL

1

Thomas ● 1 year ago

Although I partly agree with the responsibility of the module developer, I wonder what feature requires third party modules to be included during the update process. We're having similar issues but unfortunately we can't rewrite our code because Guzzle is a dependency of on of our own dependencies.

If you ask me WHMCS should make an effort to either keep its dependencies up-to-date or allow for better separation between composer packages in WHMCS and modules. I understand that Guzzle 5 is still in maintenance but version 6 was released in 2015 already, it was released before the version you're currently using.

Either way a big +1 from me.

URL

1

Björn Strausmann ● 7 months ago

1 year later... Nothing changed...

URL

1

Websavers ● 7 months ago

Guzzle 5 is now EOL: https://github.com/guzzle/guzzle#version-guidance

No more bug and security fixes... it's most definitely time to update to Guzzle 6.x. It's not even close to a discussion anymore: it's an imperative.

URL

1

Björn Strausmann ● 6 months ago

Yeah,

Now it happened, in WHMCS an outdated HTTP client without security updates is used. It is not that this request is already over a year old.

I still remember the excuse. They wanted to ensure the greatest possible compatibility with the modules. My modules based on Guzzle 6 fell by the wayside, because my modules blocked the cronjob of WHMCS, because there was a conflict with Guzzle 5 during the WHMCS update check...

Thanks WHMCS for the support ...

URL

1

Viktor Bajraktar ● 4 months ago

WHMCS 7.10 is live, now not only is the auto updater not working, but whole admin area crashes due to one of the modules is using Guzzle 6.

TypeError: Argument 3 passed to GuzzleHttp\Client::request() must be of the type array, string given, called in .../whmcs/modules/addons/.../vendor/guzzlehttp/guzzle/src/Client.php on line 87 and defined in .../whmcs/modules/addons/.../vendor/guzzlehttp/guzzle/src/Client.php:126

Stack trace:

#0 .../whmcs/modules/addons/.../vendor/guzzlehttp/guzzle/src/Client.php(87): GuzzleHttp\Client->request('createRequest', 'GET', 'https://www....')

#1 .../whmcs/vendor/whmcs/whmcs-foundation/lib/View/Admin/HealthCheck/HealthCheckRepository.php(0): GuzzleHttp\Client->__call('createRequest', Array)

#2 .../whmcs/vendor/whmcs/whmcs-foundation/lib/View/Admin/HealthCheck/HealthCheckRepository.php(0): WHMCS\View\Admin\HealthCheck\HealthCheckRepository->checkForSensitiveDirectoryRemoteAccess()

....

Honestly, I don't care about having an automatic updater as manual update does the job as well. I don't know why does the health checker keep failing now (maybe it's trying to see if there's a new version available), but why not simply implement error handling that says "Couldn't not determine the latest version. <Possible reason>" instead of crashing the page? From what I've noticed, WHMCS Updater is the only part that's having an issue with guzzle.

URL

1

RSB ● 4 months ago

This issue is affecting us as well, we'd be grateful for your consideration to upgrade Guzzle to version 6.

URL

1

ramf ● 2 months ago

This information was released by WHMCS:

Version 8.0 will be our next feature release

It will require PHP 7.2 or 7.3 ( or 7.4, once stable Ioncube loaders are available).

If you have customisations or develop modules, you will be interested to know that many of WHMCS' underlying PHP libraries will be updated. Most notably, Eloquent v7 and Guzzle v6.

URL

1

William Henryk ● 2 months ago

This issue is affecting us as well, we'd be grateful for your consideration to upgrade Guzzle to version 6.

URL

1

WHMCS John ● 2 months ago

Hi all,

I'm pleased to advise that WHMCS v8.0 will use and distribute Guzzle 6.

We explored going straight to Guzzle 7, however one of the dependencies of BitPay is blocking that at present. So Guzzle 7 is something we are monitoring and will re-evaluate in future.

Please keep an eye on https://blog.whmcs.com in the coming weeks for more information on this next feature release!

URL