How can we improve WHMCS?

Share, discuss and vote for what you would like to see added to WHMCS

Updating Client Currency on Account - Invoicing Retained with Old Currency.

  • PretecsChris shared this idea 11 years ago
  • Admin Area
  • 47 Comments


174 Votes
Login to Vote
If a client requests us to switch their currency on their account, that all previous invoicing remain in the old currency and new invoices will be shown in the new currency. From an accounting purpose, this is a huge issue with the archived information not matching what currency they paid in, and this should be retained for perpetuity.

It would also be helpful if the client could set on a product level, not on a client level, what currency they wish to pay in.
Merged Ideas
    currency per invoice - add field to database determine the payment currency type
    Hello,We have customers that they pay sometimes with eur, sometimes with usd. To set the currency to the invoice, not to the customer will be best update and will finish the currency problemsThank you

68 Comments

Login to post a comment.

wating for update
When changing currency for a client, I've not noticed that WHMCS has no updated the correct pricing, so instead of charge 34usd, im charging 34 mexican peso. 20 pesos is 1 dollar, so imagine how this BUG are broken my business.
Is any solution there?

Thanks in advance
You should not change the currency of a client. WHMCS doesn't store currency value for invoices therefore it also doesn't update pricing. It simply changes currency prefix and suffix.

For example let's say that you have a client with an invoice of 100 INR. As soon as you change to EUR, the invoice becomes 100 EUR but in reality 100 INR are equal to 1.41 EUR so it's a disaster.

There are modules in the Marketplace that allow you to freely change the currency of a client without messing up with existing invoices.
Here's what we've been doing - which you could automate with some database queries if you often need to switch currencies. (Perhaps one of those modules does something similar - I never checked.)

* Set the client's profile to Inactive or Closed (or whatever status you don't send e-mails to.)
* Change their e-mail from [email protected] to [email protected]/USD (or whatever currency it is.)
* Create a new profile for the [email protected] using the new currency.
* Move products from the old to the new client.
* Update products pricing to use their new currency.

This way their old invoices remain properly stored in the old currency while new invoices are generated in the new currency. You can switch back and forth whenever you want, without compromising the invoices.

Two shortcomings of this approach: 1) The client cannot access the invoices in the inactive account, unless you teach them to login with /USD to see the old invoices. 2) It only fixes the currency issue. Other changes (like name and address) will still change whenever the customer changes them. (Which is illegal in most places.)
Just store currency per invoice and not per customer and this will fix many issues.
i request this before 3 months, please like my request too, to apply this update urgently.
I think the point here is very clear. This is not a feature request it's a bug WHMCS should consider it urget and fix it
One customer requested me to change the currency today and when I done it WHMCS just changed the PREFIX/SUFFIX of currency and kept all transactions, invoices, payments, etc. with wrong value. What to do in this case? This an extremly serious bug that must be fixed ASAP. I really don't believe that no one reported this before and if reported, why your development team doesn't fixed yet.

This is completely wrong for accounting. When an invoice is created
WHMCS should store the currency, amount, exchange rate (in case of conversion), etc. All invoices/transactions/etc shouldn't suffer changes. This is something that must be rethought urgently.
It's not a bug. This is how WHMCS handles currency change. Basically you should not allow clients to change their currency since this value is crucial and not intended to change. There are 2 possible solution:
  • Create a new account for your client with his/her new currency setting and move all domains/products from the old one. Of course keep the old account still alive as a reference
  • There are modules that allow you to "cache" currency prefix and suffix so that you can freely change this value for every client
Actually I disagree. If you are not supposed to change your customer currency and it's a bug like you mentioned, then it would not be there in the first place. WHMCS would not have this option if what you said is true. The option is there because its something users requested and WHMCS added it. The bug here is that WHMCS changes the currency symbol on all the invoices and transactions. It should only change the new ones, not past ones. This is the bug people complain, they don't complain about the feature that changes the currency in the customer account (as that works) but how its changing it.
I like Linus Torwalds quote here. If enough people are using or rely on a bug then its not a bug anymore, it's a feature. Changing currency is something that people want and request as you can see here for the simple reason that a customer may want to change his currency. A simple example of this is someone moving from Europe to the US and now wants his invoices in USD instead of Euros or the other way around. WHMCS can change currency without issues in the customer account, the bug here is that it also changes them for past transactions and invoices because all it does its update the currency symbol in the SQL database. This is actually amazingly dumb to fix. All they need to check is the time stamp or date and freeze those records so they are not changed when you hit the change currency button. This way the change will apply to new transactions and invoices but not past ones.
I'd forgotten I'd subscribed to this, since the original request was filed in 2013! As others have said, this isn't a feature request, it's a bug....or at the very least a flawed implementation.
I agree. You can't change invoices once emitted. Actually, that is the law everywhere. I don't know anywhere, US, Europe, or any other country where that is actually allowed.

The strange thing is that I don't understand why WHMCS is even doing this. Its extremely easy just to apply the new currency to new invoices, and leave the past ones alone because WHMCS does not actually update the amount on the old invoices, it just updates the currency symbol on them. This is not a rocket science and I had to disable the currency feature for this reason as well.
Retaining the currency alone is not sufficient. Past invoices have to be retained exactly as they were sent out. In many countries this is simply the law, not something up for debate.

Currently we can't allow a customer to change their currency or their address without either breaking the law (because it modifies past invoices!) or creating an entirely new profile for them.

IMHO the inability to be compliant with the law without creating a new profile is a serious bug, not a missing feature.
Just another demonstration of how extremely poor this functionality is thought out:
If you have taken steps to change the currency to, for example, EUR: you already had to jump through multiple hoops due to WHMCS not allowing people to switch currency (as it pretends they always paid in that currency, which already is a huge flaw). So you had to run some queries to fix the currency values...Next up: you have to retain the USD packages and create new EUR packages for new orders right? That way, your existing clients keep paying in USD, and your new clients finally get the new currency...Well... To make that story even better: that ensures that everyone who once paid in USD and has their account set to USD: they can't place new orders anymore because the system won't allow them to order in EUR! I'm not even joking... Their entire order will be thrown out, or when they're logged in: it will not throw an error during order but just show blank boxes... Great going WHMCS... This function is so very *very* messed up for a billing "solution", it's really extraordinary ridiculous. To make it this flawed requires really quite some skill.
Guys, these problems can be prevented by using our Cached invoices module.

It saves all the necessary data about each created invoice to the database, including the currency and even it's number format. The module even displays the right currency for the invoice while you're viewing it from the admin area.
So, in a nutshell...the process looks like this:

invoice gets generated -> data gets written to a database thus preventing stupid changes for all of the older invoices if the user decides to use a different currency after that -> if invoice is paid, module creates a PDF file locally (optional) thus preventing ANY changes in the future...invoice stays the same forever, even if you change your WHMCS theme and the user gets the same invoice data, no matter when he tries to view/download it. So, you're happy, your accountant is happy...
You can even edit the data for each saved invoice and change the currency afterwards if you want, among other things.

Check out the WHMCS forums thread -> http://forum.whmcs.com/showthread.php?95294-M-BIT-Cached-Invoices-Addon-Module-for-WHMCS-Keep-your-invoices-intact-forever!


We're open to all sugestions, don't be shy.
As I have already said in my previous comment, it's possible to fix this issue with a custom modification (addon module + hook + few lines of code in invoice PDF). I don't think that WHMCS is interested in fixing this because on paper it's not a bug. It's how WHMCS is meant to be used. Sad but true :)
Agreed.
This is a *HUGE* mess.

Changing the currency for a client resulting in all past invoices (paid or not) going to that currency as well is ridiculous. It shouldn't work like that at all, and it is a bit strange for an accounting tool to have such a major bug inside of it.

If a client moves from USA to Europe for example, or vice versa, and now wants to pay in that currency: it should be possible! Without all the trouble.
It also causes issues for business owners within the EU as they will have to do a currency conversion for every payment not received in EUR by clients living within the eurozone and having to pay taxes...

This must be fixed.
How did you blocked it?

As far as I know, this feature can be implemented if the PHP code checks for the value on invoices "Unpaid" and the issue is solved. WHMCS should only change them on this invoices and not others. All other invoices with a status which is not "Unpaid" should be skipped and its currency symbol untouched.
I forgot to update this open feature request. I managed to fix this issue "blocking" particular values on my invoices such as name, lastname, vat id and of course currency symbol too. Now clients can freely change their default currency. All invoices keep the "original" currency value.
Absolutely. This is a huge mess. Its not uncommon for a customer to request his account to be changed to another currency. Example, you have customers in Europe but just now you started to offer products in Euros. Its only normal for this customers which where paying in your default currency to want to change to Euros now.

Another example is someone moving to another country. Lets say they move from Europe to the states and want now their current account in USD.

Said this, currently its a major accounting mess.

Changing the currency changes the currency symbol on past invoices which is a bug. Since if the customers paid 120$ in one invoice, and 12$ in another invoice, you changed his account to Euros and now it says he paid 120EUR and 12EUR.

This is a major bug. Paid invoices [u]should not have their symbol changed[/u] and problem solved. Open invoices would change to the current new EUR value in this example but PAID/CANCELED invoices should not be touched. It seems rather than a feature request this is a WHMCS bug. It changes the currency symbol on all the invoices for that customer.

How hard can it be to make a pre-check on the PHP code that runs this?All it needs to do is skip the invoices that have the status PAID/REFUNDED/CANCELLED.